You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix option configuration examples : prepend rules with "ava/".
FMI: Do you guys prefer to always add code via PRs, or can/should I push this kind of simple fix directly on master? There's no contribution guidelines for maintainers or anything, so I don't know what you agreed on.
If it's obvious or trivial, you can just push to master. Especially if it's just documentation.
Remember, you can't fix mistakes with a --force push on master (that is a big no-no), you have to push a separate "fixup" or "revert" commit. There are lots of ways something can go wrong (you forgot to run the linter one last time, you forgot to save that new dependency in package.json, you forgot some language feature isn't supported in node 0.10, etc), so I usually prefer to just do a PR, or push to a separate branch on the main repo and verify CI passes before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix option configuration examples : prepend rules with "ava/".
FMI: Do you guys prefer to always add code via PRs, or can/should I push this kind of simple fix directly on master? There's no contribution guidelines for maintainers or anything, so I don't know what you agreed on.